Development: Fix and enable exam assessment complaint tests

[muradium]

Checklist

General

• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Client

• I strictly followed the client coding and design guidelines.
• I documented the TypeScript code using JSDoc style.

Motivation and Context

E2E tests for a user flow of "complaining for exam assessment feedback and response to those complaints" are not working and skipped in Playwright.

Description

Fixes E2E tests about exam complaints and enables them.

Steps for Testing

• Code Review: Ensure that tests pass for valid reasons, functionality is adequately tested, and check the code quality.
• Run the tests (optional): Tests are checked by automatic run in CI environment. You can optionally run them locally and check if they pass.

Steps for running the tests:

1. Navigate to src/tests/playwright
2. Configure Playwright using playwright.env file based on your local setup. Current configuration should work for default Artemis setup.
3. Run npm install && npm run playwright:setup && npx playwright test e2e/exam/ExamAssessment.spec.ts
4. Confirm that following tests pass:

• Complaints about modeling exercises assessment
• Complaints about programming exercises assessment
• Complaints about text exercises assessment

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

[coderabbitai]

Walkthrough

The recent modifications primarily enhance the ExamAssessment.spec.ts by removing outdated test.fixme() placeholders and integrating a new event listener for dialog handling. These changes aim to improve the robustness and coverage of test scenarios related to exam assessments.

Changes

File Path	Change Summary
.../playwright/e2e/exam/ExamAssessment.spec.ts	Removed test.fixme() and added dialog event listener

Possibly related issues

• Enable StudentExamIntegrationTests #8291: The changes could support the broader integration testing objectives for student exams by enhancing test reliability.
• Enable ExamParticipationIntegrationTest > testGetExamScore #8297: The modifications might align with efforts to enable and stabilize specific test methods, such as testGetExamScore, within exam-related test suites.

---

Recent Review Details

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between fd4125d and 55cdcc9.

Files selected for processing (1)

• src/test/playwright/e2e/exam/ExamAssessment.spec.ts (4 hunks)

Additional comments not posted (1)

src/test/playwright/e2e/exam/ExamAssessment.spec.ts (1)

305-305: Addition of event listener for dialog handling.

This change is crucial for handling dialogs automatically during the complaint process. Ensure that this event listener does not interfere with other dialog interactions within the same test suite.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[rstief]

Code LGTM

[pzdr7]

Code 👍
Demonstrated working tests during testing session

[coolchock]

lgtm