-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Allow overriding any template resource file
#8380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
server
Pull requests that update Java code. (Added Automatically!)
labels
Apr 11, 2024
b-fein
force-pushed
the
enhancement/allow-overriding-template
branch
from
April 11, 2024 17:17
80dd5db
to
05274b3
Compare
b-fein
temporarily deployed
to
artemis-test4.artemis.cit.tum.de
April 11, 2024 17:34
— with
GitHub Actions
Inactive
b-fein
temporarily deployed
to
artemis-test3.artemis.cit.tum.de
April 11, 2024 17:43
— with
GitHub Actions
Inactive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
src/test/java/de/tum/in/www1/artemis/service/ResourceLoaderServiceTest.java
Outdated
Show resolved
Hide resolved
b-fein
force-pushed
the
enhancement/allow-overriding-template
branch
from
April 11, 2024 17:58
05274b3
to
78bbcfa
Compare
Strohgelaender
approved these changes
Apr 11, 2024
b-fein
force-pushed
the
enhancement/allow-overriding-template
branch
from
April 15, 2024 07:37
78bbcfa
to
d8101cd
Compare
BaumiCoder
approved these changes
Apr 15, 2024
julian-christl
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
ready to merge
server
Pull requests that update Java code. (Added Automatically!)
small
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@coderabbitai ignore
Checklist
General
Server
Motivation and Context
The resource loader contains a as far as I can tell fairly arbitrary restriction that only files in
templates/jenkins/
can be overridden by placing a identically named file next to the Artemis executable.(arbitrary in so far as it was only needed for configurable Jenkins pipelines back then in #2306, but quite a few other features where it makes sense have been added since)
I would however also like to override other templates, e.g. the code of conduct readme.md, the data export readme.
Description
This PR removes the restriction to allow only to override files in
templates/jenkins/
but allows all files intemplates/
instead.Steps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Code Review
Manual Tests
Test Coverage
unchanged