Programming exercises: Include mode selection in validation status

[milljoniaer]

Checklist

Client

• I strictly followed the client coding and design guidelines.
• Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
• I documented the TypeScript code using JSDoc style.
• I added multiple screenshots/screencasts of my UI changes.
• I translated all newly inserted strings into English and German.

Motivation and Context

When both Allow offline IDE and online editor are not checked, the mode section in programming exercises should be invalid.

Description

This PR includes the specific validation.

Steps for Testing

Prerequisites:

• 1 Instructor

1. Log in to Artemis
2. Create Programming exercise, Check uncheck these boxes
3. verify that validation bar shows correct state of mode section

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Screenshots

Summary by CodeRabbit

• New Features

  • Implemented real-time validation checks for modifying difficulty settings in the programming exercise update form.

• Bug Fixes

  • Enhanced validation logic in the programming exercise update wizard for accurate step validation based on IDE selections.

• Tests

  • Added tests to ensure proper functionality of form status sections and validations in the programming exercise update scenario.

[coderabbitai]

Walkthrough

The updates involve enhancing the validation mechanisms in the programming exercise management components of an application. Changes include new event bindings for triggering validation and modifications in validation logic to ensure the robustness of form status and difficulty settings.

Changes

File Path	Change Summary
.../programming-exercise-update.component.html	Added event binding for validation trigger in jhi-programming-exercise-difficulty component.
.../programming-exercise-update.component.ts	Updated validation logic in ProgrammingExerciseUpdateComponent to include validIdeSelection().
.../update-components/programming-exercise-difficulty.component.html	Added (ngModelChange) to trigger validation on checkbox changes.
.../update-components/programming-exercise-difficulty.component.ts	Introduced EventEmitter for validation triggering in ProgrammingExerciseDifficultyComponent.

Possibly related issues

• Issue Key: Programming exercises: Add Athena Feedback Suggestions #7094: The enhanced validation mechanisms could potentially support the system design changes needed for integrating feedback suggestions, ensuring robust data handling and user interactions.
• Issue Key: Programming Exercise: Changing the short name while importing breaks tests #7188: Changes in validation and event handling might impact how exercise settings (like short names) are managed without affecting related functionalities, potentially addressing issues with settings during import.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[rstief]

Code LGTM!

[MaximilianAnzinger]

Fix looks good, I'd still like a test :)

[MaximilianAnzinger]

Thank you for adding the test 👍
Code LGTM

[rabeatwork]

maintainer approve

[egekurt123]

Tested on ts2, works as expected

[JohannesWt]

Tested - works as expected

[Jan-Thurner]

Code LGTM