-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Refactor deprecated usage of throwError
#8386
Development
: Refactor deprecated usage of throwError
#8386
Conversation
WalkthroughThe recent modifications across various test specifications primarily focus on refining error handling and improving code readability. Changes include the adoption of arrow functions for error generation, enhancing the structure of mock return values, and reformatting object declarations for clarity. These adjustments ensure more robust and maintainable test suites, aligning with best practices in error management and code presentation. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank You!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 9
src/test/javascript/spec/component/course/course-overview.component.spec.ts
Show resolved
Hide resolved
src/test/javascript/spec/component/course/course-overview.component.spec.ts
Show resolved
Hide resolved
src/test/javascript/spec/component/course/course-overview.component.spec.ts
Show resolved
Hide resolved
src/test/javascript/spec/component/course/course-overview.component.spec.ts
Show resolved
Hide resolved
src/test/javascript/spec/component/lecture/lecture-attachments.component.spec.ts
Show resolved
Hide resolved
src/test/javascript/spec/component/lecture/lecture-attachments.component.spec.ts
Show resolved
Hide resolved
...javascript/spec/component/programming-exercise/programming-exercise-detail.component.spec.ts
Show resolved
Hide resolved
...javascript/spec/component/programming-exercise/programming-exercise-detail.component.spec.ts
Show resolved
Hide resolved
src/test/javascript/spec/component/participation/participation.component.spec.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, and Coderabbit is drunk.
Checklist
General
Motivation and Context
export declare function throwError(error: any): Observable<never>;
is deprecated and should therefore be replaced byexport declare function throwError(errorFactory: () => any): Observable<never>;
Review Progress
Code Review
Summary by CodeRabbit