Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Regenerate Aeolus LocalCI build scripts #8390

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

b-fein
Copy link
Contributor

@b-fein b-fein commented Apr 13, 2024

@coderabbitai ignore

Checklist

General

Changes affecting Programming Exercises

  • High priority: I tested all changes and their related features with all corresponding user types on a test server configured with the integrated lifecycle setup (LocalVC and LocalCI).

Motivation and Context

The Windfiles CI check kept failing in other unrelated PRs due to changes in the scripts, e.g. #8388, #8323:

7a8
> 
File ./src/main/resources/templates/aeolus/java/plain_gradle.yaml has changed

Description

Fixes the ‘Check if windfiles and scripts match’ CI step.

This PR ensures the additional final newlines in multiline strings are always removed.
I’m not sure why it started failing for only this case, as far as I can tell the multiline string block for plain_gradle.yaml looks the same as in the other build scripts.

Some of the build scripts already made use of the final newline removal (c/gcc.yaml on develop right now):


Therefore, this is supported by Aeolus. This PR unifies the behaviour across all build scripts.

Steps for Testing

Code review is enough. As you can see there, only empty lines are removed in the generated shell scripts.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

coderabbitai[bot]

This comment was marked as spam.

@ls1intum ls1intum deleted a comment from coderabbitai bot Apr 13, 2024
Copy link
Contributor

@pzdr7 pzdr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code

@krusche krusche modified the milestones: 7.0.1, 7.0.2 Apr 22, 2024
@krusche krusche merged commit 00f9c2b into develop Apr 22, 2024
37 of 42 checks passed
@krusche krusche deleted the regenerate-aeolus-java branch April 22, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants