Development: Fix flaky postgres test

[Strohgelaender]

Checklist

General

• I tested all changes and their related features with all corresponding user types on a test server.
• This is a small issue that I tested locally and was confirmed by another developer on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Motivation and Context

The test testResetCategories is flaky on postgess.

Description

The test compared a Set against a List, leading to test failures by expecting the Set to be ordered. The test also used a bit of an hack to compare StaticCodeAnalysisCategory objects with StaticCodeAnalysisDefaultCategory which I replaced by a explicit mapping. Lastly, I converted StaticCodeAnalysisDefaultCategory into a record.

Steps for Testing

code review

Review Progress

Code Review

• Code Review 1
• Code Review 2

Summary by CodeRabbit

• Refactor
  • Simplified and improved the code structure for static code analysis by utilizing Java streams and records for mapping and updating category properties.
• Bug Fixes
  • Ensured consistency and accuracy in handling static code analysis categories by adjusting method calls and property access.
• Tests
  • Updated test methods to validate the static code analysis functionalities accurately post the recent code enhancements.

[coderabbitai]

Walkthrough

The changes in this update involve refactoring Java classes and methods within the Artemis project related to static code analysis. These changes focus on enhancing code clarity and efficiency by utilizing Java records, stream operations for data manipulation, and adjusting method calls for property access.

Changes

Files	Change Summary
.../StaticCodeAnalysisDefaultCategory.java .../StaticCodeAnalysisCategoryRepository.java .../StaticCodeAnalysisService.java	Refactored to use Java records, updated method calls to lowercase, and streamlined data handling with Java streams.
.../programmingexercise/ProgrammingExerciseTestService.java .../programmingexercise/StaticCodeAnalysisIntegrationTest.java	Updated method calls to match the new record structure and implemented Java stream collectors in test methods.

Possibly related issues

• Exam: Divide the Testing Process into Steps #6621: The changes in this PR do not directly address the objectives outlined in the issue related to test compilation and execution control during exams.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[florian-glombik]

Code changes are looking good to me, using a record seems reasonable and like a better choice.

Thanks for using explicit typing instead of var 😄

[pzdr7]

Code

[laadvo]

Code looks good, thanks for fixing this common cause of flakyness :)