Development: Fix several server code issues
#8405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
server
src/main/java/de/tum/in/www1/artemis/service/AuthorizationCheckService.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/service/connectors/gitlabci/GitLabCIService.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/service/connectors/jenkins/JenkinsService.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/service/connectors/localci/LocalCIResultService.java
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/service/connectors/localci/LocalCIService.java
Outdated
Show resolved
Hide resolved
...ava/de/tum/in/www1/artemis/service/tutorialgroups/TutorialGroupChannelManagementService.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/web/rest/ModelingAssessmentResource.java
Show resolved
Hide resolved
src/test/java/de/tum/in/www1/artemis/util/IrisUtilTestService.java
Outdated
Show resolved
Hide resolved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
src/main/java/de/tum/in/www1/artemis/service/connectors/gitlabci/GitLabCIService.java
Outdated
Show resolved
Hide resolved
Strohgelaender
previously approved these changes
Apr 16, 2024
julian-christl
dismissed stale reviews from Strohgelaender and coderabbitai
via
5a2cc9d
Strohgelaender
approved these changes
Apr 16, 2024
JohannesStoehr
approved these changes
Apr 17, 2024
MaximilianAnzinger
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Server
Motivation and Context
With Java 21, several new code issues came up so I decided to sweep through the inspections and fix the ones that made sense.
Description
See above. Ask me if you have questions about a specific change. It's too many details to summarise them here.
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Code Review