-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Add gitHub action outputting the changed files
#8407
Development
: Add gitHub action outputting the changed files
#8407
Conversation
changed another file to test action
…ing-endpoint-connections' into development/github-action-analyzing-endpoint-connections
Co-authored-by: Lucas Welscher <ga53foy@mytum.de>
…of the head and base of a PR
Co-authored-by: Timor Morrien <timor.morrien@tum.de>
Co-authored-by: Timor Morrien <timor.morrien@tum.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked through the action with Jan in person and it looks good 🚀
Just one thing: It would be great if you would describe in your PR description why this is needed for your following work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments.
d4d1e04
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me (as someone with basic knowledge about GitHub actions)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good + Jan showed me results of a successful test.
Checklist
General
Motivation and Context
Currently, there is no feasible way to compare and analyze endpoint connections. This has to be done manually. As there are many endpoints and the generation of URIs is often profoundly nested, this is tedious and error-prone. Developers, maintainers, and reviewers have to spend significant amounts of time going through the process over and over again for every PR.
As for all involved parties, only the changes of the specific PR are relevant, they should be the only ones shown to them. This makes the review process less overwhelming and faster.
Description
This GitHub action forms the foundation of the analysis of endpoint connections on Artemis. It will print the files changed in a PR to the GitHub action's output. As for a single PR, only the changes made within that PR are to be code-reviewed by developers and maintainers, the analysis of endpoint connections focuses only on modified parts of the code, ensuring the feedback is relevant and concise.
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Code Review
Summary by CodeRabbit