Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Add gitHub action outputting the changed files #8407

Merged

Conversation

Jan-Thurner
Copy link
Contributor

@Jan-Thurner Jan-Thurner commented Apr 16, 2024

Checklist

General

Motivation and Context

Currently, there is no feasible way to compare and analyze endpoint connections. This has to be done manually. As there are many endpoints and the generation of URIs is often profoundly nested, this is tedious and error-prone. Developers, maintainers, and reviewers have to spend significant amounts of time going through the process over and over again for every PR.

As for all involved parties, only the changes of the specific PR are relevant, they should be the only ones shown to them. This makes the review process less overwhelming and faster.

Description

This GitHub action forms the foundation of the analysis of endpoint connections on Artemis. It will print the files changed in a PR to the GitHub action's output. As for a single PR, only the changes made within that PR are to be code-reviewed by developers and maintainers, the analysis of endpoint connections focuses only on modified parts of the code, ensuring the feedback is relevant and concise.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Summary by CodeRabbit

  • New Features
    • Enhanced GitHub Actions workflow to analyze and display modified files in specific directories on pull requests.

@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Apr 16, 2024
Co-authored-by: Lucas Welscher <ga53foy@mytum.de>
coderabbitai[bot]
coderabbitai bot previously approved these changes Apr 16, 2024
Co-authored-by: Timor Morrien <timor.morrien@tum.de>
coderabbitai[bot]
coderabbitai bot previously approved these changes Apr 16, 2024
Co-authored-by: Timor Morrien <timor.morrien@tum.de>
coderabbitai[bot]
coderabbitai bot previously approved these changes Apr 16, 2024
Hialus
Hialus previously approved these changes Apr 16, 2024
Copy link
Member

@Hialus Hialus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked through the action with Jan in person and it looks good 🚀

Just one thing: It would be great if you would describe in your PR description why this is needed for your following work.

@Jan-Thurner Jan-Thurner marked this pull request as ready for review April 16, 2024 19:10
@Jan-Thurner Jan-Thurner requested a review from a team as a code owner April 16, 2024 19:10
Copy link
Contributor

@MarkusPaulsen MarkusPaulsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

@Jan-Thurner Jan-Thurner dismissed stale reviews from coderabbitai, pzdr7, and Hialus via d4d1e04 April 20, 2024 14:08
coderabbitai[bot]
coderabbitai bot previously approved these changes Apr 20, 2024
pzdr7
pzdr7 previously approved these changes Apr 20, 2024
@Jan-Thurner Jan-Thurner dismissed stale reviews from pzdr7 and coderabbitai via 766469f April 22, 2024 08:13
Copy link
Contributor

@florian-glombik florian-glombik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (as someone with basic knowledge about GitHub actions)

Copy link
Contributor

@MarkusPaulsen MarkusPaulsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good + Jan showed me results of a successful test.

@krusche krusche added this to the 7.0.2 milestone Apr 25, 2024
@krusche krusche merged commit d146bf5 into develop Apr 25, 2024
9 of 10 checks passed
@krusche krusche deleted the development/github-action-analyzing-endpoint-connections branch April 25, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

create basic GitHub Action as Foundation for the Visualization of Endpoint Connections
8 participants