-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Disable redundant cypress tests
#8431
Conversation
WalkthroughThe recent modifications primarily focus on managing the execution of test suites in a Cypress environment. Numerous test suites across different modules like exams, courses, and exercises have been selectively skipped or isolated for execution. This includes significant use of Changes
This table groups files with similar changes, providing a clear and concise summary of the modifications made to the test execution strategy in the Cypress test suites. Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (35)
Files skipped from review due to trivial changes (27)
Additional comments not posted (8)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
@@ -47,7 +47,7 @@ courseConfigsToTest.forEach((configToTest) => { | |||
}); | |||
}); | |||
|
|||
it('instructor should be able to select answer', () => { | |||
it.only('instructor should be able to select answer', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tip
Codebase Verification
The verification process has confirmed that the it.only
method is used exclusively in the CourseCommunication.cy.ts
file to focus on a specific test case. This usage could unintentionally prevent other tests in the suite from running when the test suite is executed, which might not align with the typical goals of maintaining comprehensive test coverage in a production environment.
Please review and confirm whether the inclusion of it.only
is intended for the final merge or if it should be removed to allow all tests in the suite to run.
- File and Line:
src/test/cypress/e2e/course/CourseCommunication.cy.ts
line 50
Analysis chain
Focus on a specific test case using it.only
.
The use of it.only
here isolates this test case, ensuring that only this test is executed when the test suite runs. This is typically used during development for debugging or focusing on a specific issue. If this change is intended for the final merge, it might prevent other tests in the suite from running, which could reduce test coverage unintentionally. Please confirm if this change is meant to be temporary or if it should be included in the final commit.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for other occurrences of `it.only` in the Cypress test files to ensure it's not unintentionally left in other tests.
rg --type ts 'it.only' src/test/cypress
Length of output: 167
Since we want to migrate away from Cypress, would it make sense to remove these tests already instead of skipping them? |
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
General
: Disable redundant cypress testsDevelopment
: Disable redundant cypress tests
Checklist
General
Client
Motivation and Context
We migrated our E2E test suite from Cypress to Playwright. As a result, most of the tests in Cypress are now redundant and we want to disable them.
Description
This PR disables majority of the tests in Cypress and only leaves the ones that either don't exist in Playwright yet or are currently faulty in Playwright.
Steps for Testing
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Code Review
Manual Tests
Summary by CodeRabbit