Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Fix style of exercise footer for dark mode #8442

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

rabeatwork
Copy link
Contributor

@rabeatwork rabeatwork commented Apr 19, 2024

Checklist

General

  • This is a small issue that I tested locally and was confirmed by another developer on a test server.

Motivation and Context

image

Description

image

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 1 Exercise
  1. Log in to Artemis
  2. Navigate to Course Administration
  3. Edit/Add an exercise
  4. Verify that the footer looks good

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked






Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Exam Mode Test

  • Test 1
  • Test 2

Summary by CodeRabbit

  • Style
    • Updated the footer background color in the dark theme for improved visual coherence.

@rabeatwork rabeatwork requested a review from a team as a code owner April 19, 2024 12:37
Copy link

coderabbitai bot commented Apr 19, 2024

Walkthrough

The update involves a modification in the styling of a web application by changing the background color variable of the footer in the dark theme settings. This alteration transitions the footer's background from a brighter shade to a more neutral, darker tone, enhancing the theme's consistency and visual appeal.

Changes

File Path Change Summary
.../scss/themes/_dark-variables.scss Updated $update-footer-background from $brighter-body-bg to $neutral-dark.

Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 520cd65 and 068aa1d.
Files selected for processing (1)
  • src/main/webapp/content/scss/themes/_dark-variables.scss (1 hunks)
Additional comments not posted (1)
src/main/webapp/content/scss/themes/_dark-variables.scss (1)

319-319: Change to $footer-background variable looks good for enhancing dark mode consistency.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Apr 19, 2024
Copy link
Contributor

@egekurt123 egekurt123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested on ts5, works as expected.

@krusche krusche changed the title Bug: Fix style of exercise footer for dark mode General: Fix style of exercise footer for dark mode Apr 22, 2024
@krusche krusche added this to the 7.0.2 milestone Apr 22, 2024
@krusche krusche merged commit d4a4a1a into develop Apr 22, 2024
40 of 46 checks passed
@krusche krusche deleted the Fix-exercise-footer-padding-for-dark-mode branch April 22, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants