Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Enable exam tests #8480

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Conversation

FelixTJDietrich
Copy link
Contributor

@FelixTJDietrich FelixTJDietrich commented Apr 26, 2024

Checklist

General

Server

Motivation and Context

Closes #8305 #8291

Description

Re-enable failing test due to Atlassian migration.

Steps for Testing

Not necessary, only changes in tests.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked






Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Test Coverage

Enabled tests

Summary by CodeRabbit

  • New Features
    • Enhanced integration with ProgrammingExerciseUtilService for improved exercise management in testing environments.
  • Tests
    • Enabled the previously disabled unlockAllRepositories test method, allowing it to run and verify repository unlocking functionality during programming exams.

Copy link

coderabbitai bot commented Apr 26, 2024

Warning

Rate Limit Exceeded

@FelixTJDietrich has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 27 minutes and 30 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 0fcfd55 and 35710e4.

Walkthrough

The changes involve enhancing test functionalities within the Artemis project. A dependency (ProgrammingExerciseUtilService) was added to the GitlabRequestMockProvider for better test setup management in GitLab-related tests. Additionally, a test method in ProgrammingExamIntegrationTest was re-enabled to ensure it runs during test executions, enhancing the test coverage and reliability of programming exams.

Changes

File Path Change Summary
.../connector/GitlabRequestMockProvider.java Added ProgrammingExerciseUtilService dependency injection and invoked related method.
.../exam/ProgrammingExamIntegrationTest.java Removed @Disabled annotation from unlockAllRepositories test method.
.../exam/StudentExamIntegrationTest.java Updated annotations to remove @Disabled from several test methods.

Assessment against linked issues

Objective Addressed Explanation
Enable ProgrammingExamIntegrationTest > unlockAllRepositories (#8305) The PR successfully enables the unlockAllRepositories test method.
Ensure the test accurately retrieves the exam score (#8297) The changes do not relate to exam score retrieval or the ExamParticipationIntegrationTest class.
Address test case replacement during exam creation process (#6621) Changes are unrelated to test case management during exam programming exercises.
Prevent test.json file breakage due to short name change during import (#7188) No changes related to handling of test.json or exercise import procedures.
Refactor LinkPreviewIntegrationTest to use mocks (#8054) The changes do not involve the LinkPreviewIntegrationTest or its refactoring.

Possibly related issues

  • Issue Enable ExamParticipationIntegrationTest > testGetExamScore #8297: Although the PR re-enables a test method in ProgrammingExamIntegrationTest, it does not directly address the enabling or functionality of the testGetExamScore method in ExamParticipationIntegrationTest. Hence, it's indirectly related but not directly addressing the issue's objectives.
  • Issue Development: Refactor LinkPreviewIntegrationTest #8054: The PR involves changes in test functionalities but does not address the specific needs of refactoring LinkPreviewIntegrationTest to use mocks. Therefore, it's not related to this PR.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot previously approved these changes Apr 26, 2024
@FelixTJDietrich FelixTJDietrich changed the title Development: Enable ProgrammingExamIntegrationTest > unlockAllRepositories Development: Enable StudentExamIntegrationTests and ProgrammingExamIntegrationTest > unlockAllRepositories Apr 26, 2024
@FelixTJDietrich FelixTJDietrich force-pushed the chore/enable-unlockAllRepositories branch from 92a1d66 to 35710e4 Compare April 26, 2024 12:28
@FelixTJDietrich FelixTJDietrich changed the title Development: Enable StudentExamIntegrationTests and ProgrammingExamIntegrationTest > unlockAllRepositories Development: Enable some tests Apr 26, 2024
@FelixTJDietrich FelixTJDietrich changed the title Development: Enable some tests Development: Enable exam tests Apr 26, 2024
@bassner bassner added this to the 7.0.2 milestone Apr 26, 2024
@bassner bassner merged commit 262b3ee into develop Apr 26, 2024
23 of 27 checks passed
@bassner bassner deleted the chore/enable-unlockAllRepositories branch April 26, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Enable ProgrammingExamIntegrationTest > unlockAllRepositories
3 participants