-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrated code lifecycle
: Fix an issue with binary file conversions before build execution
#8519
Conversation
Instructions to create a minimal working example as specified here: https://artemis-staging-localci.artemis.cit.tum.de/course-management/86/programming-exercises/626. Create a new python programming exercise, for example with our custom docker image: Store a binary file in the test repository, for example:
Write a test that loads the binary file:
Push the repository containing the binary file and the test case that reads the file. This test will fail on Artemis: Numpy cannot read the binary file and will throw an error because the file is corrupted. |
This does unfortunately cause issues for Java Gradle exercises (at least locally with Windows):
Does anyone know the issue here? Other exercises including Java Maven do not seem to be affected. Also, no problem on unix systems (LocalCI Staging) |
I couldn't replicate the original issue on Windows or Ubuntu. But I also get the same issue as @laurenzfb on Windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not try to replicate the original issue, but experience a comparable where the gradle wrapper jar did not work correctly. After commenting out this line the build worked correctly.
I'm also on Windows and did not experience the issue mentioned above. However, if this is an issue for the script.sh file, we should limit replacing line endings just for this file. (This should probably be done in BuildJobContainerService#configureContainer since here the SCRIPT
variable is set)
WalkthroughThe recent update involves a minor adjustment in the Java project, specifically within the Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review due to trivial changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Checklist
General
Server
Changes affecting Programming Exercises
Motivation and Context
A file conversion from Windows to Unix is also applied to binary files and leads to issues
Description
We remove the file conversion because it does not seem to be necessary any more.
Steps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Performance Review
Code Review
Manual Tests