-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General
: Fix exercise archival for courses and exams
#8527
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-tested on my local machine after changes.
src/test/java/de/tum/in/www1/artemis/service/export/CourseExamExportServiceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/de/tum/in/www1/artemis/service/export/CourseExamExportServiceTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the exam mode on ts2, exporting the finished exam with partitipations in all exercises worked without any problems. I was able to download the archive 👍
a104d96
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove exam mode test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing my comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exam mode:
Tested on TS3: Created exam
- Created exam with 5 exercise groups each with a different exercise type
- Participated with a student
- end exam
- Archive Exam -> No errors
- Archive file downloadable
Normal mode:
Tested locally:
- Created 5 exercises (programming, modeling, and text exercise with plagiarism / Text exercise in teams)
- Create a team for text exercise
- Participated with a student in all exercises
- end course
- Archive Exam -> No errors
- Archive file downloadable
Checklist
General
Server
Motivation and Context
Fixes #8521
Description
Steps for Testing
Prerequisites:
Exam Mode Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Performance Review
Code Review
Manual Tests
Exam Mode Test
Test Coverage
Only significant change coverage-wise was an auto-transformation if-else to switch-case.