Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programming exercises: Improve tooltips and exercise summary on the instructor details page #8530

Conversation

florian-glombik
Copy link
Contributor

@florian-glombik florian-glombik commented May 2, 2024

Checklist

General

Client

  • I added multiple screenshots/screencasts of my UI changes.
  • I translated all newly inserted strings into English and German.

Motivation and Context

Improve usability of the programming exercise creation process by adjusting translations and displayed information.

Description

  • Hiding build plan ids in exercise summary if the setup is using localVC
  • Adding description tooltip for auxiliary repositories
  • Fixing translations within auxiliary repository table
  • Removing tooltip beside created auxiliary repositories

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 1 Programming exercise on localVC setup
  1. Check that the build plan ids are not displayed in the programming exercise details view, if the setup is using localVC.
  2. In the programming exercise creation / edit page, check that the "Add auxiliary repository" button has a useful tooltip.
  3. In the programming exercise creation / edit page, check that the auxiliary repository table has correct translations.
  4. In the programming exercise creation / edit page, check that the tooltip beside the created auxiliary repositories are not displayed anymore

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked






Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Screenshots

Change Before Now
Hide build plan ids image image
Add Aux Repo tooltip image image
Fix Aux Repo table translations image image
Removed Aux Repo tooltips image Tooltips not displayed on hover image

@florian-glombik florian-glombik self-assigned this May 2, 2024
@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label May 2, 2024
@florian-glombik florian-glombik added this to the 7.0.3 milestone May 2, 2024
@florian-glombik florian-glombik changed the title Programming exercises:Update tooltips and exercise summary to align with LocalCI Programming exercises: Update tooltips and exercise summary to align with LocalCI May 3, 2024
@florian-glombik florian-glombik changed the title Programming exercises: Update tooltips and exercise summary to align with LocalCI Programming exercises: Update tooltips and align exercise summary to align with LocalCI May 3, 2024
@florian-glombik florian-glombik changed the title Programming exercises: Update tooltips and align exercise summary to align with LocalCI Programming exercises: Update tooltips and exercise summary to align with LocalCI May 3, 2024
@florian-glombik florian-glombik marked this pull request as ready for review May 3, 2024 06:48
@florian-glombik florian-glombik requested a review from a team as a code owner May 3, 2024 06:48
Copy link

coderabbitai bot commented May 3, 2024

Walkthrough

The changes in this update encompass refining user interface elements and localization aspects for programming exercises in a web application. These enhancements involve conditional rendering updates, tooltip refinements, and the incorporation of translated texts to improve user accessibility and comprehension.

Changes

Files Change Summary
.../programming-exercise-detail.component.ts
.../programming-exercise-plans-and-repositories-preview.component.html
.../programming-exercise-information.component.html
.../help-icon-without-translation.component.ts
Enhanced UI components to facilitate conditional rendering, refined tooltips, and integrated localization for improved clarity and user experience.
i18n/de/programmingExercise.json
i18n/en/programmingExercise.json
Introduced new localization fields for auxiliary repositories to support multiple languages efficiently.

Possibly related issues

  • Issue Programming exercises: Add Athena Feedback Suggestions #7094: The changes made to programming-exercise-detail.component.ts align with the objective of providing feedback suggestions for programming exercises, enhancing the user experience with conditional rendering based on localVCEnabled.
  • Issue Missing Build plans of imported exercise #7439: While not directly related, the enhancements in the UI components could indirectly contribute to addressing inconsistencies in imported exercises by improving the display and management of build plans based on conditions like localVCEnabled.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between e549460 and 66bf1ca.
Files selected for processing (1)
  • src/main/webapp/i18n/en/programmingExercise.json (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • src/main/webapp/i18n/en/programmingExercise.json

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot previously approved these changes May 3, 2024
…te-tooltips-and-summary-to-align-with-localci' into chore/programming-exercises/update-tooltips-and-summary-to-align-with-localci
coderabbitai[bot]
coderabbitai bot previously approved these changes May 3, 2024
pzdr7
pzdr7 previously approved these changes May 3, 2024
Copy link
Contributor

@pzdr7 pzdr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS2. Looks good 👍

  • No build plan IDs ✅
  • Aux repo tooltip ✅
  • Aux repo table ✅
  • No tooltip for aux repo in preview ✅

src/main/webapp/i18n/en/programmingExercise.json Outdated Show resolved Hide resolved
@florian-glombik florian-glombik dismissed stale reviews from pzdr7 and coderabbitai via 66bf1ca May 3, 2024 10:21
@florian-glombik florian-glombik requested a review from pzdr7 May 3, 2024 10:21
Copy link
Contributor

@pzdr7 pzdr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@krusche krusche changed the title Programming exercises: Update tooltips and exercise summary to align with LocalCI Programming exercises: Improve tooltips and exercise summary on the instructor details page May 3, 2024
@krusche krusche merged commit 64ba2de into develop May 3, 2024
24 of 28 checks passed
@krusche krusche deleted the chore/programming-exercises/update-tooltips-and-summary-to-align-with-localci branch May 3, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) ready for review small
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants