Lectures: Fix an issue with a readonly validation for attachments

[az108]

Motivation and Context

Issue was fixed where, during the Creation of Lecture Units the version tab would show object object instead of a value.
#8439

Description

I added the intended value to version and removed the readonly as it was redundant. The readonly is considered in the html file already and the value 1 is still readonly after the changes.

Steps for Testing

Prerequisites:

• 1 Instructor

1. Log in to Artemis
2. Navigate to Course Administration
3. Navigate to Lecture Unit
4. Then Create

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Performance Review

• I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Summary by CodeRabbit

Summary by CodeRabbit

• Refactor
  • Simplified the data structure and interactions related to grading criteria in exercises by removing the handling of pointsPerCriterion across various components and services. This change streamlines the process of managing exercise scores and results, enhancing the user experience by focusing on essential data.

[coderabbitai]

Walkthrough

The update simplifies the initialization of the version field in the AttachmentUnitFormComponent, removing the disabled property to streamline the field setup and potentially enhance interactivity.

Changes

File Path	Change Summary
.../attachment-unit-form/attachment-unit-form.component.ts	Simplified initialization of version field by removing the disabled property.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b73d08d and 645b424.

Files selected for processing (1)

• src/main/webapp/app/lecture/lecture-unit/lecture-unit-management/attachment-unit-form/attachment-unit-form.component.ts (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• src/main/webapp/app/lecture/lecture-unit/lecture-unit-management/attachment-unit-form/attachment-unit-form.component.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

⚠️ Unable to deploy to test servers ⚠️

The docker build needs to run through before deploying.

[github-actions]

⚠️ Unable to deploy to test servers ⚠️

Testserver "artemis-test2.artemis.cit.tum.de" is already in use by PR #8526.

[sarpsahinalp]

Tested on ts2 works as expected!

[Jan-Thurner]

code lgtm

[iyannsch]

Works as expected, the object object is now a 1 - good job there :)

One small feedback aspect though, it took me 15 mins just to find the part you changed in the Artemis Lecture/Unit Management system. In the course, I created a text-based Unit, which is obviously not affected by your changes nor the initial bug.
In future, I´d love to see you write a bit more detail in the "Reviewer Nudging" to help me recreate the fault. I was just able to detect it now, as the issue's title contains pdf 👀😂

Thanks for your work!

[az108]

I will keep that in mind thanks!

[az108]

works after the commit change aswell. Tested it locally

[maximiliansoelch]

Thanks for implementing the suggestion, the linked issue is solved 👍

[egekurt123]

LGTM

[sarpsahinalp]

Reapprove

[az108]

Thanks for implementing the suggestion, the linked issue is solved 👍

Thanks for suggesting :)