Add new pipeline DTOs #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hialus
requested changes
Feb 14, 2024
There was a problem hiding this comment.
2 general suggestions:
- Define the attributes on the class level (like you'd in Java). This makes it clearer what attributes each model has.
- Since these will be used as DTOs in FastAPI it would be beneficial if they use Pydantic for parsing them to/from JSON. For this they simply have to implement
BaseModeland either have no init method or call super with all attributes the class has.
Hialus
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some initial DTOs to use as deserialization targets in the endpoint subsystem as well as inputs in the pipeline subsystem.