Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filesizes shown in bytes not colored with size.medium and size.large #841

Closed
pstray opened this issue Apr 24, 2023 · 2 comments
Closed

Filesizes shown in bytes not colored with size.medium and size.large #841

pstray opened this issue Apr 24, 2023 · 2 comments
Labels
good first issue Good for newcomers kind/enhancement Enhancement on current feature

Comments

@pstray
Copy link

pstray commented Apr 24, 2023

  • os: linux
  • lsd --version: lsd 0.23.1

Expected behavior

I had hoped for files colors be applied to sizes even when '--size bytes'.

Actual behavior

With '--size bytes', all files sizes are colored with size.small
@zwpaper zwpaper added kind/enhancement Enhancement on current feature good first issue Good for newcomers labels Apr 28, 2023
@bells307 bells307 mentioned this issue Jun 15, 2023
Merged
2 tasks
zwpaper pushed a commit that referenced this issue Jun 21, 2023
@bells307
Fixed file size colorizing with --size=bytes argument (#856)
8ea79c6 
<!--- PR Description --->

Fixed incorrect colorizing with `--size=bytes` described in issue #841 

---
#### TODO

- [x] Use `cargo fmt`
- [x] Add changelog entry

---------

Co-authored-by: Bells307 <sdikansky96@gmail.com>
@zwpaper
Copy link
Member

zwpaper commented Jul 4, 2023

/close

as #856 merged

@muniu-bot muniu-bot bot closed this as completed Jul 4, 2023
@muniu-bot
Copy link

muniu-bot bot commented Jul 4, 2023

@zwpaper: Closing this issue.

In response to this:

/close

as #856 merged

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers kind/enhancement Enhancement on current feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pstray @zwpaper