-
-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use terminal color scheme #90
Comments
Hello @chmln, As everyone has its own color theme it will be very difficult to make everyone happy. There is a currently a PR (#84) which aim to integrate the This is sound as a solution to your problem? |
Hey, thanks for responding so fast! While Fixed colors make more sense for webpages, but not so much for terminals where the background colors can vary a lot. Powershell, for instance, has a dark blue background by default. I use dark gray. In both cases, contrast suffers. Support for built-in colors would be a huge usability win. Its rather easy to implement proper ANSI color support. It would entail just using e.g. |
I fear the will be not enough colors with the basic ANSI colors. Most of the peoples expects to find the same result than the README but there color theme would change it and it could be deceptive. There is another possible solution: as proposed into #92, it could be a good idea to propose a configuration file with a custom theme. |
As we will not directly implement the proposed solution I set this issue as close |
Would you be open to using terminal color scheme behind a flag? It really does seem like expected behavior; CLI tools usually respect terminal colors. |
It seems that a lot of people want this feature so I reopen this issue in order to find a solution. I see three solutions:
The first solution seems to be the most standard one, that why I would tend to choose this one but it include a big fat change for current users and that's not good... Any suggestions? |
I don't think that it'll be so destructive to the existing users. See how |
I like the first option too. We could also add custom colors behind a flag in the future. You are correct that it would change existing colors for users so perhaps we could bump the semver version to indicate that. That being said, maybe color changes are not breaking functional changes. What do you think? |
My vote would be to default to ansi similar to exa then introduce theme support (#92) for people that want to fully customize colors. |
I'm sorry I don't have much time in the next few days so I hope that someone would like to make a PR. I should be a easy one because there is not logic changes. |
I can take a look. |
@thekashifmalik That would be awesome, I can help you if you need any help with navigating the codebase. |
@Kevin-Mok From what I can understand from here, this happens because fish sets the @Peltoche A simple fix would be completely let lscolors take care of colors. |
This would be the best solution. |
Expected behavior
lsd
uses colors from my terminal color scheme, being consistent with all the other command line tools.Actual behavior
It appears
lsd
uses hard-coded colors, instead of the terminal color scheme. The hard coded colors don't look as nice. See screenshot below.My terminal colors:
The text was updated successfully, but these errors were encountered: