Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lscolors to 0.9.0 #623

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Bump lscolors to 0.9.0 #623

merged 2 commits into from
Feb 18, 2022

Conversation

meain
Copy link
Member

@meain meain commented Feb 13, 2022

Fixes #248

Just a note for future: I am not bumping crossterm as they have changed the deserialize code to not deserialize 0 into 256 color 0, but now you have to write ansi_0. We might have to create custom deserialize for that. We can maybe change back to ansi-term while we are at it as that has 16 color support which could be useful for #609.

ref: crossterm-rs/crossterm#604

Also bumping min rust version in CI to 1.56.0 as we need that for lscolors to use edition 2021.


TODO

  • Use cargo fmt
  • Add necessary tests
  • Add changelog entry

@meain meain requested a review from Peltoche as a code owner February 13, 2022 17:30
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2022

Codecov Report

Merging #623 (e494fbf) into master (4120f68) will decrease coverage by 0.17%.
The diff coverage is 26.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #623      +/-   ##
==========================================
- Coverage   86.12%   85.95%   -0.18%     
==========================================
  Files          37       37              
  Lines        3907     3915       +8     
==========================================
  Hits         3365     3365              
- Misses        542      550       +8     
Impacted Files Coverage Δ
src/color.rs 49.14% <0.00%> (-2.36%) ⬇️
src/meta/mod.rs 39.51% <0.00%> (ø)
src/meta/date.rs 98.55% <66.66%> (ø)
src/flags/date.rs 94.59% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4120f68...e494fbf. Read the comment docs.

@meain meain merged commit 082c822 into lsd-rs:master Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for non-bold bright colours
2 participants