Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move locale based date behind a flag #840

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Conversation

meain
Copy link
Member

@meain meain commented Apr 24, 2023

This makes sure the date behaviour is kept to previous default.
#828


TODO

  • Use cargo fmt
  • Add necessary tests
  • Add changelog entry
  • Update default config/theme in README (if applicable)
  • Update man page at lsd/doc/lsd.md (if applicable)

@meain meain requested a review from Peltoche as a code owner April 24, 2023 04:39
@meain meain requested a review from zwpaper April 24, 2023 04:40
@codecov-commenter
Copy link

Codecov Report

Merging #840 (60597a7) into master (ff3e48e) will increase coverage by 0.02%.
The diff coverage is 91.66%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #840      +/-   ##
==========================================
+ Coverage   87.42%   87.45%   +0.02%     
==========================================
  Files          45       45              
  Lines        4302     4320      +18     
==========================================
+ Hits         3761     3778      +17     
- Misses        541      542       +1     
Impacted Files Coverage Δ
src/app.rs 39.28% <50.00%> (ø)
src/meta/date.rs 94.28% <93.75%> (-0.25%) ⬇️
src/flags/date.rs 95.77% <100.00%> (+0.18%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zwpaper zwpaper merged commit 4c09647 into lsd-rs:master Apr 26, 2023
17 checks passed
@meain meain deleted the date-locale branch April 27, 2023 02:47
zwpaper pushed a commit that referenced this pull request Feb 12, 2024
This flag is added by #840
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants