Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make .profile have the same icon as profile #850

Merged
merged 2 commits into from Jun 22, 2023
Merged

Conversation

alichtman
Copy link
Contributor

@alichtman alichtman commented May 28, 2023

  • Use cargo fmt
  • Add necessary tests
  • Add changelog entry
  • Update default config/theme in README (if applicable)
  • Update man page at lsd/doc/lsd.md (if applicable)

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2023

Codecov Report

Merging #850 (67ca51a) into master (bafc495) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #850   +/-   ##
=======================================
  Coverage   87.06%   87.06%           
=======================================
  Files          49       49           
  Lines        4800     4800           
=======================================
  Hits         4179     4179           
  Misses        621      621           
Impacted Files Coverage Δ
src/theme/icon.rs 98.78% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alichtman
Copy link
Contributor Author

@zwpaper Any chance you could stamp this too?

@zwpaper zwpaper self-requested a review as a code owner June 22, 2023 06:37
@zwpaper
Copy link
Member

zwpaper commented Jun 22, 2023

hi @alichtman, sorry for missing the PR, I was kinda busy recently.

/lgtm
/approve

@muniu-bot muniu-bot bot added the lgtm label Jun 22, 2023
@alichtman
Copy link
Contributor Author

No problem! Thanks!

@zwpaper
Copy link
Member

zwpaper commented Jun 22, 2023

/approve

@muniu-bot
Copy link

muniu-bot bot commented Jun 22, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alichtman, zwpaper

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zwpaper zwpaper merged commit d97e7c4 into lsd-rs:master Jun 22, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants