Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬇️ change dirs to 4 #916

Merged
merged 1 commit into from Sep 28, 2023
Merged

⬇️ change dirs to 4 #916

merged 1 commit into from Sep 28, 2023

Conversation

zwpaper
Copy link
Member

@zwpaper zwpaper commented Sep 28, 2023

after upgrading to version 5, the windows build kept failing.

this PR rollback to version 4

ref: https://github.com/lsd-rs/lsd/actions/runs/6315869413/job/17149313870

logs:

   Compiling chrono-humanize v0.1.2
   Compiling windows v0.43.0
   Compiling terminal_size v0.1.17
   Compiling human-sort v0.2.2
   Compiling xdg v2.1.0
   Compiling vsort v0.1.0
error: linking with `i686-w64-mingw32-gcc` failed: exit code: 1
Error:   |
  = note: "i686-w64-mingw32-gcc" "-fno-use-linker-plugin" "-Wl,--dynamicbase" "-Wl,--disable-auto-image-base" "-Wl,--large-address-aware" "C:\\Users\\runneradmin\\.rustup\\toolchains\\stable-i686-pc-windows-gnu\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\self-contained\\crt2.o" "C:\\Users\\runneradmin\\.rustup\\toolchains\\stable-i686-pc-windows-gnu\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\rsbegin.o" "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustcKR6IIc\\symbols.o" "D:\\a\\lsd\\lsd\\target\\i686-pc-windows-gnu\\release\\deps\\lsd-86ed8d7be09e32c8.lsd.2b58fa958a916b9a-cgu.0.rcgu.o" "-L" "D:\\a\\lsd\\lsd\\target\\i686-pc-windows-gnu\\release\\deps" "-L" "D:\\a\\lsd\\lsd\\target\\release\\deps" "-L" "C:\\Users\\runneradmin\\.cargo\\registry\\src\\index.crates.io-1cd66030c949c28d\\winapi-i686-pc-windows-gnu-0.4.0\\lib" "-L" "C:\\Users\\runneradmin\\.cargo\\registry\\src\\index.crates.io-1cd66030c949c28d\\windows_i686_gnu-0.42.1\\lib" "-L" "C:\\Users\\runneradmin\\.cargo\\registry\\src\\index.crates.io-1cd66030c949c28d\\windows_i686_gnu-0.36.1\\lib" "-L" "C:\\Users\\runneradmin\\.cargo\\registry\\src\\index.crates.io-1cd66030c949c28d\\windows_i686_gnu-0.48.5\\lib" "-L" "C:\\Users\\runneradmin\\.rustup\\toolchains\\stable-i686-pc-windows-gnu\\lib\\rustlib\\i686-pc-windows-gnu\\lib" "-Wl,-Bstatic" "C:\\Users\\runneradmin\\.rustup\\toolchains\\stable-i686-pc-windows-gnu\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\libcompiler_builtins-9b4f51620e29a8ea.rlib" "-Wl,-Bdynamic" "-lwindows" "-lwindows" "-lwindows" "-lwindows.0.48.5" "-lwindows" "-lwinapi_advapi32" "-lwinapi_cfgmgr32" "-lwinapi_gdi32" "-lwinapi_kernel32" "-lwinapi_msimg32" "-lwinapi_opengl32" "-lwinapi_synchronization" "-lwinapi_user32" "-lwinapi_winspool" "-lkernel32" "-ladvapi32" "-lbcrypt" "-lkernel32" "-lntdll" "-luserenv" "-lws2_32" "-lkernel32" "-lws2_32" "-lkernel32" "-lgcc_eh" "-l:libpthread.a" "-lmsvcrt" "-lmingwex" "-lmingw32" "-lgcc" "-lmsvcrt" "-luser32" "-lkernel32" "-Wl,--nxcompat" "-nostartfiles" "-L" "C:\\Users\\runneradmin\\.rustup\\toolchains\\stable-i686-pc-windows-gnu\\lib\\rustlib\\i686-pc-windows-gnu\\lib" "-L" "C:\\Users\\runneradmin\\.rustup\\toolchains\\stable-i686-pc-windows-gnu\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\self-contained" "-o" "D:\\a\\lsd\\lsd\\target\\i686-pc-windows-gnu\\release\\deps\\lsd-86ed8d7be09e32c8.exe" "-Wl,--gc-sections" "-no-pie" "-Wl,-O1" "-Wl,--strip-all" "-nodefaultlibs" "C:\\Users\\runneradmin\\.rustup\\toolchains\\stable-i686-pc-windows-gnu\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\rsend.o"
  = note: 

error: could not compile `lsd` (bin "lsd") due to previous error
Error: The process 'C:\Users\runneradmin\.cargo\bin\cargo.exe' failed with exit code 101

TODO

  • Use cargo fmt
  • Add necessary tests
  • Update default config/theme in README (if applicable)
  • Update man page at lsd/doc/lsd.md (if applicable)

Signed-off-by: Wei Zhang <kweizh@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #916 (2593f91) into master (c8f1d75) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #916      +/-   ##
==========================================
- Coverage   85.78%   85.74%   -0.04%     
==========================================
  Files          51       51              
  Lines        5003     5003              
==========================================
- Hits         4292     4290       -2     
- Misses        711      713       +2     

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@muniu-bot
Copy link

muniu-bot bot commented Sep 28, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zwpaper

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zwpaper zwpaper merged commit 1714d89 into lsd-rs:master Sep 28, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants