-
-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: directory name ending with extention are not prepended with ext … #973
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: atamakahere-git The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #973 +/- ##
==========================================
+ Coverage 84.34% 84.54% +0.19%
==========================================
Files 53 51 -2
Lines 5111 5078 -33
==========================================
- Hits 4311 4293 -18
+ Misses 800 785 -15 ☔ View full report in Codecov by Sentry. |
In macOS, directores with extensions do have special meanings. For example, |
I will do some research/tests and get back on this, If any suggestion let me know. |
538eba2
to
106ba28
Compare
@CarterLi Hey, I did some changes that exclude special named directory. |
@zwpaper Hey, are you thinking of adding this enhancement to lsd? |
7883e61
to
0bad9f3
Compare
Tried fixing #965
TODO
cargo fmt