Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After remove the worker from the cluster, it is better to set the rank id to -1. #276

Closed
rankeey opened this issue Apr 17, 2020 · 3 comments
Closed

After remove the worker from the cluster, it is better to set the rank id to -1. #276

rankeey opened this issue Apr 17, 2020 · 3 comments

Comments

@rankeey
Copy link
Collaborator

rankeey commented Apr 17, 2020

No description provided.

@lgarithm
Copy link
Collaborator

After the worker is removed from the cluster, the APIs like current_rank and current_cluster_size shouldn't be called anymore. It is a bug that we don't throw exceptions when those APIs are called after worker removed.

@rankeey
Copy link
Collaborator Author

rankeey commented Apr 17, 2020

Throwing exception is ok.

@luomai
Copy link
Member

luomai commented Jun 24, 2020

We have added a detached function to let worker check if it is still part of the cluster.

@luomai luomai closed this as completed Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@luomai @lgarithm @rankeey