3 Ripper bugfixes from Ruby trunk #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 8, 2011 17:17
This commit fixes an issue where LHS vars are not parsed in the presence of an LHS star/splat.
This commit adds ripper events to words and qwords nodes.
This commit corrects the inconsistent ordering of rescue_mod node children.
This is a breaking change in Ripper output, targeted for Ruby 1.9.3.
lsegal
added a commit
that referenced
this pull request
Sep 28, 2011
3 Ripper bugfixes from Ruby trunk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Howdy Loren,
The following bugs were reported and fixed, and are being released in Ruby 1.9.3:
http://redmine.ruby-lang.org/issues/4364
http://redmine.ruby-lang.org/issues/4365
http://redmine.ruby-lang.org/issues/4716
I've merged the fixes into ripper18. Including them should introduce no backwards incompatibility issues by consumers of ripper18, because they were instances of just flat-out incorrect behavior by Ripper. Relying on their previous behavior would likely have been disastrous.