Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ssh git links to be used. #89

Closed
wants to merge 2 commits into from
Closed

Allow ssh git links to be used. #89

wants to merge 2 commits into from

Conversation

errm
Copy link
Contributor

@errm errm commented Feb 5, 2015

Links in the form of git@github.com:lsegal/yard.git
are now the default on github so it makes sense to
have the example in that format too.

Supporting SSH links makes running a private instance
nicer.

Mostly a duplication of #71 but drops the config
switch stuff in favour of just using the ssh format
everywhere.

Links in the form of git@github.com:lsegal/yard.git
are now the default on github so it makes sense to
have the example in that format too.

Supporting SSH links makes running a private instance
nicer.

Mostly a duplication of #71 but drops the config
switch stuff in favour of just using the ssh format
everywhere.
@lsegal
Copy link
Collaborator

lsegal commented Feb 6, 2015

I don't mind supporting this, but I wouldn't recommend users use it. The git@github.com:... URL format only works when you have SSH keys with permission to access the repository, as opposed to the public format which allows anyone to access. Rubydoc would always prefer the public URL.

If you reverted the changes to the suggested URL / docs I can accept the other changes to the internal support.

As a sidenote, git@github syntax is not the default, at least not for me. GitHub seems to default to the https://github.com/foo/bar syntax.

@errm
Copy link
Contributor Author

errm commented Feb 7, 2015

Ok, perhaps we should recommend the https syntax.
It looks like the default clone url is sticky on github if you are logged in so you see whatever you last chose, and if you are logged out you see the https url, so it should recommend that one.

It might be worth allowing the ssh urls for public repos as well, but it would mean creating a machine user on github and adding your deploy users public key.

On a private instance, with private repos the ssh url is the only option as the https one prompts for login.

@errm errm closed this Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants