-
-
Notifications
You must be signed in to change notification settings - Fork 392
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
3 changed files
with
70 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| name: Linux | ||
|
|
||
| on: [push, pull_request] | ||
| jobs: | ||
| build: | ||
| name: >- | ||
| Linux | Ruby: ${{ matrix.ruby }} | ||
| runs-on: "ubuntu-latest" | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| ruby: ["2.4.x", "2.5.x", "2.6.x", "9.9.x"] | ||
| steps: | ||
| - name: repo checkout | ||
| uses: actions/checkout@v1 | ||
| with: | ||
| fetch-depth: 10 | ||
| - name: load ruby, update gcc | ||
| uses: MSP-Greg/actions-ruby@master | ||
| with: | ||
| ruby-version: ${{ matrix.ruby }} | ||
| base: update | ||
| - name: update RubyGems, Bundler | ||
| run: gem update --system --no-document --conservative | ||
| - name: bundle install | ||
| run: bundle install --jobs=3 --retry=3 | ||
| - name: test | ||
| run: | | ||
| ruby -v | ||
| bundle exec rake | ||
| env: | ||
| CI: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| name: macOS | ||
|
|
||
| on: [push, pull_request] | ||
| jobs: | ||
| build: | ||
| name: >- | ||
| macOS | Ruby: ${{ matrix.ruby }} | ||
| runs-on: "macos-latest" | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| ruby: ["2.4.x", "2.5.x", "2.6.x", "9.9.x"] | ||
| steps: | ||
| - name: repo checkout | ||
| uses: actions/checkout@v1 | ||
| with: | ||
| fetch-depth: 10 | ||
| - name: load ruby, update gcc | ||
| uses: MSP-Greg/actions-ruby@master | ||
| with: | ||
| ruby-version: ${{ matrix.ruby }} | ||
| base: update | ||
| - name: update RubyGems, Bundler | ||
| run: gem update --system --no-document --conservative | ||
| - name: bundle install | ||
| run: bundle install --jobs=3 --retry=3 | ||
| - name: test | ||
| run: | | ||
| ruby -v | ||
| bundle exec rake | ||
| env: | ||
| CI: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
00a65d2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ruby "9.9.x" (ruby master) only exists in Windows workflows, not Ubuntu or macOS. It's being worked on.
Windows can have "2.7.x" added if you'd like.
00a65d2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MSP-Greg I switched over to eregon/use-ruby-action because it supports Ruby 2.7 on all platforms. See 112a890.
As far as a 9.9.x equivalent goes, it's not really necessary just yet.
00a65d2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Actually, it also uses current releases, the Actions Rubies are a little old on all platforms.
Do you want a windows specific step added to install the missing gems (probably a few days)?
EDIT: Forgot,
actions/checkout@v1is now atactions/checkout@v200a65d2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MSP-Greg a Windows specific step would be great yea.
00a65d2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MSP-Greg actually it turns out redcloth/redcarpet are actually compiling just fine on Windows systems, the pending issues were mostly just due to poorly written tests and some weird runtime mingw things that we're working around in f4f02ba.