Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C parsing, class parent/superclass resolution #1079

Closed
MSP-Greg opened this issue Mar 23, 2017 · 0 comments
Closed

C parsing, class parent/superclass resolution #1079

MSP-Greg opened this issue Mar 23, 2017 · 0 comments

Comments

@MSP-Greg
Copy link
Contributor

MSP-Greg commented Mar 23, 2017

When viewing docs for the pg repo or the pg gem, many of the superclasses are not being resolved correctly. Class List shows many of these.

In the c source, many of the rb_define_class_under calls have a space between the final paren and the 'parent' parameter.

I believe that stripping this space will allow correct lookup. It could be done in the several places, in the handler regex, the handler process call, or YARD:: Handlers::C::HandlerMethods#handle_class. The regex in the handler has a comment about 'SWIG', which I'm not familiar with.

Hence, given the options for where to do so, I haven't done a PR...

I don't think that root classes are affected by this, as the regex doesn't pick up spaces in the final parent param.

Steps to reproduce

NA

Actual Output

NA

Expected Output

NA

Environment details:

  • OS: Win7
  • Ruby version: ruby 2.5.0dev (2017-03-19 trunk 58021) [x64-mingw32]
  • YARD version: 0.9.8

I have read the Contributing Guide.

@lsegal lsegal closed this as completed in e91d41c Apr 24, 2017
lsegal added a commit that referenced this issue Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant