Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add irb slex remove e2mmap #1297

Merged
merged 2 commits into from Dec 31, 2019
Merged

Add irb slex remove e2mmap #1297

merged 2 commits into from Dec 31, 2019

Conversation

lsegal
Copy link
Owner

@lsegal lsegal commented Dec 31, 2019

Description

Based on #1296 but without e2mmap dependency.

Completed Tasks

  • I have read the Contributing Guide.
  • The pull request is complete (implemented / written).
  • Git commits have been cleaned up (squash WIP / revert commits).

koic and others added 2 commits December 26, 2019 20:29
@koic
Support Ruby 2.7.0
7e61560 
Follow up of #1290 (comment).

This is a workaround path for Ruby 2.7.0.

`irb/slex` internal API has been removed in the following commits.
ruby/ruby@45bb6f2

This PR copies the above file to lib/yard/parser/ruby/legacy/irb/slex.rb.

Hopefully this workaround patch will be dropped along with legacy Ruby code
in the future.

And E2MM (e2mmap gem) is no longer bundled gems.
https://www.ruby-lang.org/en/news/2019/12/25/ruby-2-7-0-released/

```console
% cd path/to/repo/yard
% ruby -v
ruby 2.7.0p0 (2019-12-25 revision 647ee6f091) [x86_64-darwin17]
% bundle exec rake

(snip)

LoadError:
  cannot load such file -- e2mmap
  # ./lib/yard/parser/ruby/legacy/ruby_lex.rb:1:in `require'
  # ./lib/yard/parser/ruby/legacy/ruby_lex.rb:1:in `<top (required)>'
```

This PR adds `e2mmap` gem to the gemspec. And this dependency on `e2mmap`
could be removed when `irb/slex` is removed in the future.
@lsegal
Remove e2mmap dependency when vendoring irb/slex
9999128
@lsegal lsegal merged commit be6b21e into master Dec 31, 2019
@lsegal lsegal deleted the add-irb-slex-remove-e2mmap branch December 31, 2019 20:05
@coveralls
Copy link

coveralls commented Dec 31, 2019 •
edited

Coverage Status

Coverage decreased (-0.7%) to 92.784% when pulling 9999128 on add-irb-slex-remove-e2mmap into ebd6269 on master.

lsegal added a commit that referenced this pull request Dec 31, 2019
@lsegal
Tag release v0.9.21
f13462d 
References:
  #1196, #1220, #1242, #1244, #1245, #1258, #1260, #1262,
  #1263, #1269, #1274, #1276, #1284, #1288, #1290, #1294,
  #1297
@Earlopain Earlopain mentioned this pull request Dec 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lsegal @coveralls @koic