xmlSecNssGetInternalKeySlot function arguments missing

[ryandesign]

Building xmlsec 1.3.0 with clang 15 fails:

crypto.c:415:28: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
xmlSecNssGetInternalKeySlot()
                           ^
                            void
1 error generated.
make[3]: *** [libxmlsec1_nss_la-crypto.lo] Error 1 

The problem is that you haven't declared xmlSecNssGetInternalKeySlot's arguments:

xmlsec/src/nss/crypto.c

Lines 414 to 415 in 7296990

	PK11SlotInfo *
	xmlSecNssGetInternalKeySlot()

If this is to be a function that takes no arguments, you must declare it as such:

--- src/nss/crypto.c.orig	2023-04-12 11:45:12.000000000 -0500
+++ src/nss/crypto.c	2023-04-13 02:05:19.000000000 -0500
@@ -412,7 +412,7 @@
  * Returns: internal key slot and initializes it if needed.
  */
 PK11SlotInfo *
-xmlSecNssGetInternalKeySlot()
+xmlSecNssGetInternalKeySlot(void)
 {
     PK11SlotInfo *slot = NULL;
     SECStatus rv;

This was reported to MacPorts here: https://trac.macports.org/ticket/67227

[lsh123]

Thanks, I wonder why macosx build in github actions didn't catch it.

[ryandesign]

I wonder why macosx build in github actions didn't catch it.

This warning (which you turn into an error) is new in clang 15. Xcode 14.3 is the first version whose clang is based on clang 15. Xcode 14.3 requires macOS 13 or later. Your GitHub Actions configuration file uses macOS 12. GitHub Actions does not have a macOS 13 runner yet; see actions/runner-images#6426.

[lsh123]

thanks for looking into it! I will switch to the mac-13 as soon as it is available!

[ryandesign]

FYI it's available now.

[lsh123]

Thanks, PR #651