New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use non-deprecated APIs when building against openssl 3 #334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks a lot for creating this PR! I will review it this week (it's pretty big so I will need a couple days). Aleksey |
I "forked" this PR into my own PR where I will make changes as I go: I already removed the Engine for OpenSSL 3.0 for now |
lsh123
added a commit
that referenced
this pull request
May 17, 2022
Based on #334 authored by snargit
Thanks a lot for your PR! I merged my PR #336 just now. It includes everything you had plus:
I will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use non-deprecated APIs when building against openssl 3. These changes are a like-for-like replacement of the low-level API calls with the equivalent higher-level ones per the openssl porting guidelines. All the new code is behind #ifdefs so builds against older versions of openssl should be identical to the current code.
The only place I've not updated is the engine-specific key loading code in openssl/app.c as there's no direct replacement for this due to the complete deprecation of all the engine APIs in favour of the new provider design.
Tests are all passing, but there are still some compiler warnings related to size_t usage on 64-bit builds as the configure script seems to incorrectly assume that size_t is not available for 64-bit due to an explicit length check (size != 4 bytes -> no size_t).