Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various minor fixes #458

Merged
merged 8 commits into from
May 5, 2021
Merged

Various minor fixes #458

merged 8 commits into from
May 5, 2021

Conversation

hriener
Copy link
Member

@hriener hriener commented May 5, 2021

This PR makes the following changes:

  • Update to the latest version of lorina
  • New quality tests using cut_rewriting with complete AIG and XAG databases
  • Window rewriting experiment repeats rewriting until convergence
  • More test cases to improve code coverage

@coveralls
Copy link

coveralls commented May 5, 2021

Pull Request Test Coverage Report for Build 813753578

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 83.334%

Files with Coverage Reduction New Missed Lines %
include/mockturtle/algorithms/node_resynthesis/xag_npn.hpp 2 86.76%
Totals Coverage Status
Change from base Build 813371684: 0.3%
Covered Lines: 13136
Relevant Lines: 15763

💛 - Coveralls

@codecov-commenter
Copy link

codecov-commenter commented May 5, 2021

Codecov Report

Merging #458 (30acc08) into master (ea1ef3e) will increase coverage by 0.27%.
The diff coverage is 100.00%.

❗ Current head 30acc08 differs from pull request most recent head 8aec009. Consider uploading reports for the commit 8aec009 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #458      +/-   ##
==========================================
+ Coverage   82.80%   83.07%   +0.27%     
==========================================
  Files         133      133              
  Lines       15107    15113       +6     
==========================================
+ Hits        12509    12555      +46     
+ Misses       2598     2558      -40     
Impacted Files Coverage Δ
include/mockturtle/io/write_aiger.hpp 84.61% <100.00%> (ø)
...mockturtle/algorithms/node_resynthesis/xag_npn.hpp 87.30% <0.00%> (-2.87%) ⬇️
include/mockturtle/utils/node_map.hpp 98.21% <0.00%> (+0.13%) ⬆️
include/mockturtle/utils/algorithm.hpp 89.74% <0.00%> (+5.12%) ⬆️
...mockturtle/algorithms/balancing/esop_balancing.hpp 100.00% <0.00%> (+47.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea1ef3e...8aec009. Read the comment docs.

@hriener hriener merged commit c2d2337 into master May 5, 2021
@hriener hriener deleted the common branch May 5, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants