Resubstitution #54
Merged
Resubstitution #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # include/mockturtle/algorithms/detail/mffc_utils.hpp # test/algorithms/quality.cpp
msoeken
approved these changes
Jul 28, 2018
| return true; /* next */ | ||
| } | ||
|
|
||
| if ( tts[ n ] != ternary_majority( tts[ u ], binary_and( tts[ x ], tts[ y ] ), tts[ n ] ) ) |
There was a problem hiding this comment.
(tts[x] & tts[y]) could be used instead of binary_and(tts[x], tts[y])
| @@ -111,6 +116,21 @@ class fanout_view<Ntk, false> : public Ntk | |||
| _fanout[ n ].push_back( p ); | |||
| } | |||
|
|
|||
| void substitute_node_of_parents( std::vector<node> parents, node const& old_node, signal const& new_signal ) | |||
There was a problem hiding this comment.
Should std::vector<node> const& parents
| @@ -111,6 +116,21 @@ class fanout_view<Ntk, false> : public Ntk | |||
| _fanout[ n ].push_back( p ); | |||
| } | |||
|
|
|||
| void substitute_node_of_parents( std::vector<node> parents, node const& old_node, signal const& new_signal ) | |||
| { | |||
| this->substitute_node_of_parents( parents, old_node, new_signal ); | |||
There was a problem hiding this comment.
Should be Ntk::substitude_node_of_parents to call the original implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Boolean one- and two-resubstitution for MIGs (beyond node merging).