Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cost view, cost aware resynthesis problem, cost generic resub #554

Merged
merged 75 commits into from Jul 29, 2022

Conversation

Nozidoali
Copy link
Contributor

No description provided.

Nozidoali and others added 30 commits November 24, 2021 20:26
@Nozidoali Nozidoali reopened this Jul 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2022

Codecov Report

Merging #554 (8b954af) into master (826a2f0) will increase coverage by 0.03%.
The diff coverage is 86.95%.

❗ Current head 8b954af differs from pull request most recent head ad8bb59. Consider uploading reports for the commit ad8bb59 to get more accurate results

@@            Coverage Diff             @@
##           master     #554      +/-   ##
==========================================
+ Coverage   82.77%   82.81%   +0.03%     
==========================================
  Files         148      155       +7     
  Lines       18535    19151     +616     
==========================================
+ Hits        15343    15860     +517     
- Misses       3192     3291      +99     
Impacted Files Coverage Δ
include/mockturtle/views/cost_view.hpp 84.21% <84.21%> (ø)
...e/algorithms/experimental/boolean_optimization.hpp 62.26% <100.00%> (ø)
...lude/mockturtle/utils/recursive_cost_functions.hpp 100.00% <100.00%> (ø)
include/mockturtle/properties/aqfpcost.hpp 87.50% <0.00%> (-12.50%) ⬇️
...ude/mockturtle/algorithms/aqfp/detail/dag_cost.hpp 98.61% <0.00%> (-1.39%) ⬇️
...de/mockturtle/algorithms/aqfp/buffer_insertion.hpp 78.53% <0.00%> (-0.04%) ⬇️
include/mockturtle/algorithms/aqfp/detail/dag.hpp 100.00% <0.00%> (ø)
...ude/mockturtle/algorithms/aqfp/detail/dag_util.hpp 100.00% <0.00%> (ø)
.../mockturtle/algorithms/aqfp/detail/partial_dag.hpp 100.00% <0.00%> (ø)
...ude/mockturtle/algorithms/aqfp/aqfp_node_resyn.hpp 56.84% <0.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@Nozidoali Nozidoali changed the title [WIP] cost view, cost aware resynthesis problem, cost first search cost view, cost aware resynthesis problem, cost generic resub Jul 20, 2022
@Nozidoali
Copy link
Contributor Author

Nozidoali commented Jul 20, 2022

A cost-generic resubstitution algorithm with a customizable cost function.

  • Defined a new class of cost functions called "recursive cost function". Users can describe the optimization target by defining a new cost function.
  • Added a "cost view" of the network that is able to calculate the cost of both the entire network and the local window. It can be used in a resubstitution algorithm to evaluate the quality of a resubstitute candidate.
  • Implemented a "cost-aware resynthesis solver" that solves the resynthesis problem under functionality constraints and returns the dependency circuit with the lowest cost. It is an extension of the previous "xag_resyn" solver.
  • Developed a "cost-generic-resubstitution" optimization script. When calling the resubstitution algorithm, the user can specify the cost function to reduce and the script will optimize the network accordingly. Currently, only networks with base type xag_network are supported.

Copy link
Member

@lee30sonia lee30sonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't actually looked into the code yet. Please check the documentation first (make html in docs/).

docs/algorithms/cost_generic_resub.rst Outdated Show resolved Hide resolved
docs/algorithms/cost_generic_resub.rst Show resolved Hide resolved
docs/algorithms/cost_generic_resub.rst Outdated Show resolved Hide resolved
docs/views.rst Outdated Show resolved Hide resolved
include/mockturtle/views/cost_view.hpp Outdated Show resolved Hide resolved
Copy link
Member

@lee30sonia lee30sonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, but the documentation can still be clearer, especially for the part users need to modify (defining customized cost functions).

include/mockturtle/utils/recursive_cost_functions.hpp Outdated Show resolved Hide resolved
include/mockturtle/utils/recursive_cost_functions.hpp Outdated Show resolved Hide resolved
include/mockturtle/views/cost_view.hpp Outdated Show resolved Hide resolved
Copy link
Member

@lee30sonia lee30sonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Last thing: Add these items in changelog (algorithm: cost_generic_resub, view: cost_view, util: recursive_cost_functions)

@lee30sonia lee30sonia merged commit 6261bc5 into lsils:master Jul 29, 2022
@Nozidoali Nozidoali deleted the hywang/bfs branch August 29, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants