Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results for ogbg-molpcba #1

Open
chaitjo opened this issue Sep 21, 2020 · 6 comments
Open

Results for ogbg-molpcba #1

chaitjo opened this issue Sep 21, 2020 · 6 comments

Comments

@chaitjo
Copy link

chaitjo commented Sep 21, 2020

Hi, thanks for open-sourcing the code and releasing extensive experiments! GNN-specific normalization beyond BatchNorm and LayerNorm was definitely a missing component in the toolbox.

Did you experiment with GraphNorm on ogbg-molpcba (the larger and more challenging mol dataset from OGB) as well as the other graph classification tasks? Would love to know your experience or informal results.

@lsj2408
Copy link
Owner

lsj2408 commented Sep 21, 2020

Thanks for watching our work!
Indeed, we are performing further experiments on the large-scale datasets as you mentioned (ogbg-molpcba and ogbg-ppa). Moreover, we will try more GNN architectures to better understand the power of GraphNorm. The new results will be updated as soon as possible.

@chaitjo
Copy link
Author

chaitjo commented Sep 21, 2020

Awesome, keep me in the loop; looking forward to it.

@chaitjo
Copy link
Author

chaitjo commented Sep 21, 2020

If I want to use GraphNorm as a plug-and-play replacement for PyTorch's BatchNorm layer with DGL, which code snippet do you suggest?

@lsj2408
Copy link
Owner

lsj2408 commented Sep 21, 2020

Both are fine~ You could take the second one for your tasks. Just try them for free.

There is also a thrid-part implementation by Microsoft ptgnn:

@felipemello1
Copy link

felipemello1 commented Oct 22, 2020

@lsj2408, thanks for sharing this repo.

It seems that your code here is missing alpha: https://github.com/lsj2408/GraphNorm/blob/master/GraphNorm_ws/ogbg_ws/src/dgl_model/norm.py

image

Did I miss it?

@hugovergnes
Copy link

@lsj2408, thanks for sharing this repo.

It seems that your code here is missing alpha: https://github.com/lsj2408/GraphNorm/blob/master/GraphNorm_ws/ogbg_ws/src/dgl_model/norm.py

image

Did I miss it?

I think so too, looks like in the microsoft implementation above they added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants