Skip to content

Commit

Permalink
tl-its-umich-edu#1408 - Remove Vim
Browse files Browse the repository at this point in the history
To address vulnerability CVE-2021-3973, remove Vim, which was probably installed for debugging purposes.
  • Loading branch information
lsloan committed Aug 29, 2022
1 parent 069f09b commit 0cf2e1b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions dockerfiles/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ RUN npm install

# NOTE: assets/ likely to change between dev builds
COPY assets /usr/src/app/assets
RUN npm run prod
RUN npm run prod

# This is to find and remove symlinks that break some Docker builds.
# We need these later we'll just uncompress them
# We need these later we'll just uncompress them
# Put them in node_modules as this directory isn't masked by docker-compose
# Also remove src and the symlinks afterward
RUN apt-get update && \
Expand Down Expand Up @@ -40,7 +40,7 @@ WORKDIR /code
COPY requirements.txt .
RUN apt-get update && \
apt-get install -y --no-install-recommends \
build-essential default-libmysqlclient-dev libpq-dev netcat vim-tiny jq python3-dev xmlsec1 cron git && \
build-essential default-libmysqlclient-dev libpq-dev netcat jq python3-dev xmlsec1 cron git && \
apt-get upgrade -y && \
apt-get clean -y && \
rm -rf /var/lib/apt/lists/*
Expand Down
6 changes: 3 additions & 3 deletions dockerfiles/Dockerfile.openshift
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ RUN npm install

# NOTE: assets/ likely to change between dev builds
COPY assets /usr/src/app/assets
RUN npm run prod
RUN npm run prod

# This is to find and remove symlinks that break some Docker builds.
# We need these later we'll just uncompress them
# We need these later we'll just uncompress them
# Put them in node_modules as this directory isn't masked by docker-compose
# Also remove src and the symlinks afterward
RUN apt-get update && \
Expand Down Expand Up @@ -39,7 +39,7 @@ WORKDIR /code
COPY requirements.txt .
RUN apt-get update && \
apt-get install -y --no-install-recommends \
build-essential default-libmysqlclient-dev libpq-dev netcat vim-tiny jq python3-dev xmlsec1 cron git && \
build-essential default-libmysqlclient-dev libpq-dev netcat jq python3-dev xmlsec1 cron git && \
apt-get upgrade -y && \
apt-get clean -y && \
rm -rf /var/lib/apt/lists/*
Expand Down

0 comments on commit 0cf2e1b

Please sign in to comment.