Fix Laravel 10 dependency #144
Merged
+1,312
−955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution. Version 10.0 was a bug in the version release process and was fixed as soon as we noticed the problem. We kindly ask that you do not use terms like "stupid" in the community as it is considered disrespectful and aggressive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, please be careful working with versions, what is the purpose of supporting laravel packages from 9-11 but for "illuminate/support" only 9 or 11? tecnickcom/tcpdf ^6.4 || ^6.6 can be simplified just to ^6.4... Also tcpdf has security issue in version below 6.7.4. You already broke our project once by creating tag 10.0.x.x of your package and leaving this tag for several weeks...
Please merge this and make a tag 1.1.1 from this, thanks.