Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsof.8: Improve readability of complex adverbial clause in the manpage #156

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

dannykansas
Copy link
Contributor

A small change, but this paragraph trips me up every time I hit the man pages for lsof. Figured it warranted a PR if I'd noticed it enough times to think about fixing it.

Adding a comma after the adverb "Normally" should improve the readability a fair bit for future decades of lsof man page referencers.

@masatake
Copy link
Contributor

masatake commented Jun 8, 2021

@dannykansas, welcome. As a maintainer, I will show how I did. I mainly worked on the linux dialect. However, I decided to develop lsfd instead of maintaining the dialect (See #89). So you don't have to follow my way. You can do as you want. Just for your information.


Could you change the header of commit log to "man page: improve readability of complex adverbial clause by adding a comma"
or "lsof.8: improve readability of complex adverbial clause by adding a comma" ?

Adding the prefix may help you when updating the 00DIST file.

I will show you how I update 00DIST after merging this pull request.

@masatake masatake self-requested a review June 10, 2021 07:12
@masatake
Copy link
Contributor

Could you update the header of the commit log?

Copy link
Contributor

@masatake masatake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the header of commit log to "man page: improve readability of complex adverbial clause by adding a comma"
or "lsof.8: improve readability of complex adverbial clause by adding a comma" ?

@masatake
Copy link
Contributor

Ping.

@dannykansas
Copy link
Contributor Author

Commit message updated to spec (and I have now enabled my notifications for this repo!)

@dannykansas dannykansas changed the title Improve readability of complex adverbial clause in the manpage lsof.8: Improve readability of complex adverbial clause in the manpage Oct 7, 2021
@masatake
Copy link
Contributor

Please, wait for a while. I will write about what the dialect maintainer should do. I would like to show it before merging this.

@masatake masatake mentioned this pull request Oct 11, 2021
5 tasks
@masatake masatake self-assigned this Oct 11, 2021
@masatake masatake merged commit dcad998 into lsof-org:master Oct 12, 2021
@masatake masatake mentioned this pull request Oct 12, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants