Restructure the interface to map-maker and noise generator #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following fields in the structure have been changed as well: - `σ` has been renamed to `sigma` - `num_of_baselines` has been removed (it is just the length of `baselines_lengths`) A few `if`s have been converted into one-liners, and trailing whitespaces have been removed here and there.
- The code now checks that random seeds are unique among polarimeters - generate_noise_mpi now accepts three keyword parameters: `rank`, `comm`, and `input_seed` - MPI `comm` defaults to `nothing` (previously it used `missing`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nothingas the default to MPI communicators instead ofmissingdestripereturn a structure describing the convergence of the algorithm, instead of just the baselines and the map