Strictify maps #103
Merged
Strictify maps #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treeowl
force-pushed
the
strictify-maps
branch
4 times, most recently
from
4805c0a
to
92757de
Compare
|
Are you sure those are all mapping functions that need modification? What about |
Very little can actually be done to a queue without (potentially) forcing its whole spine. So leaving spines lazy for mapping and traversing gains very little performance in practice and makes performance less predictable. Closes lspitzner#100
Now that maps and unordered traversals force the result spines, `seqSpine` is no longer useful.
Good catches. I just fixed those. |
konsumlamm
approved these changes
Apr 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seqSpine. It shouldn't be needed any more.Closes #100