DM-43727: Add initial support for Alembic migrations #8
Conversation
JeremyMcCormick
force-pushed
the
tickets/DM-43727
branch
from
489e4ef
to
e28a917
Compare
alembic/env.py
Outdated
| sdm_schemas_dir = os.getenv("SDM_SCHEMAS_DIR") | ||
| if sdm_schemas_dir is None: | ||
| raise ValueError("SDM_SCHEMAS_DIR not found in environment") | ||
| schema_path = f"{sdm_schemas_dir}/yml/cdb_latiss.yaml" |
There was a problem hiding this comment.
We'll eventually need to have one of these per instrument.
How do we make sure the alembic_version table goes in the schema, not outside it? Right now, it seems to be going in the default public schema.
There was a problem hiding this comment.
Also, it looks like alembic is taking responsibility for every schema in the database, which would cause it to drop all the Butler tables. Not so good...
There was a problem hiding this comment.
We'll eventually need to have one of these per instrument.
If they all need separate migration histories then we will likely have to give them their own environments with different env.py and alembic.ini files.
There was a problem hiding this comment.
it looks like alembic is taking responsibility for every schema in the database
We can have it ignore certain schemas if their names are known:
There was a problem hiding this comment.
How do we make sure the
alembic_versiontable goes in the schema, not outside it? Right now, it seems to be going in the defaultpublicschema.
This is easily fixed in the configuration:
version_table_schema='your_custom_schema'
Though you might actually want that in a separate schema than the one being managed because the migrations themselves may drop/create it.
The URL for the live database should be specified using the CONSDB_URL, and the path to the sdm_schemas Git repository should be set using the SDM_SCHEMAS_DIR environment variable.
|
I moved the versions tables to a common |
The URL for the live database should be specified using the CONSDB_URL, and the path to the sdm_schemas Git repository should be set using the SDM_SCHEMAS_DIR environment variable.