Initial code checkin #2
Conversation
Fix issue in Message where str was returned instead of dict Fix issue in ingestd where dict was requested instead of str Update log messages to indicate why things might have been configured incorrectly Remove version.py, since it shouldn't have ever been checked in
fix yaml entry for XRD2
Fix versioning in build
| repo: /tmp/repo | ||
|
|
||
| rses: | ||
| XRD1: |
There was a problem hiding this comment.
It can sometimes be a bit awkward to have YAML keys that are user-provided. It makes it difficult to validate the files, and the syntax can sometimes be tricky if there are special characters in the key name.
The alternate way of doing this would be to have rses be a list rather than a mapping, with each list element being a mapping that contains an element like name: XRD1 in addition to rucio_prefix: and fs_prefix:.
There was a problem hiding this comment.
I went back on forth on this when I originally did it. I didn't want to list the RSE names in two places because it was just another place to make a mistake. Having said that, I can change it if you prefer.
| WORKDIR /home/lsst | ||
|
|
||
| ARG CTRL_INGESTD_GIT_VERSION | ||
| RUN git clone https://github.com/lsst-dm/ctrl_ingestd && \ |
There was a problem hiding this comment.
Better to eups distrib install this if possible. Then the whole scons command can go away.
There was a problem hiding this comment.
where are the instructions to get this to work via eups distrib install?
| @@ -0,0 +1,4 @@ | |||
| #!/bin/bash | |||
| source /opt/lsst/software/stack/loadLSST.bash | |||
| setup -r /home/lsst/ctrl_ingestd | |||
There was a problem hiding this comment.
If this is installed with eups distrib install instead of git clone, then I think this can be just setup ctrl_ingestd. (Possibly you'll need to make sure the current tag is applied in eups.)
Change to use mamba instead of pip to install Remove nc (no longer used) Update version
No description provided.