DM-32979: initial checkin of hermesk daemon mods #1
Conversation
ktlim
changed the title
| - name: Build ingest image | ||
| working-directory: docker | ||
| run: | | ||
| docker-compose -f "docker-compose.yml" --env-file versions.env build $HERMESK_NAME |
There was a problem hiding this comment.
It looks like there isn't that much in the docker-compose.yml. You might be able to use https://github.com/lsst-sqre/build-and-push-to-ghcr if you go directly to the Dockerfile.
| RUN pip install retrying | ||
|
|
||
| RUN mkdir -p /etc/grid-security/certificates | ||
| RUN mkdir /usr/local/lib/python3.9/site-packages/rucio/daemons/hermes/kafka |
There was a problem hiding this comment.
Seems a bit strange to hard-code 3.9 here. Is that because of how Rucio does things?
|
|
||
| RUN mkdir -p /etc/grid-security/certificates | ||
| RUN mkdir /usr/local/lib/python3.9/site-packages/rucio/daemons/hermes/kafka | ||
| COPY ./lib/rucio/daemons/hermes/kafka /usr/local/lib/python3.9/site-packages/rucio/daemons/hermes/kafka/ |
There was a problem hiding this comment.
It's better to copy the slowly-changing things first, then the rapidly-changing things. That way the layer cache works better.
| @@ -0,0 +1,440 @@ | |||
| version: "3" | |||
There was a problem hiding this comment.
Does this file get used anywhere? If not, can it be removed?
| @@ -0,0 +1,43 @@ | |||
| name: Build Rucio Hermes Kafka container | |||
There was a problem hiding this comment.
This file isn't used either, is it?
| @@ -0,0 +1,431 @@ | |||
| # -*- coding: utf-8 -*- | |||
| @@ -0,0 +1,21 @@ | |||
| # List EUPS dependencies of this package here | |||
There was a problem hiding this comment.
Nothing here should be needed; I don't think you even want this to be an eups package.
| @@ -0,0 +1,766 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
I'm wondering if you can't express this as a patch on the source version that you have locked. It would be a lot clearer than copying the entire file. As it is, I can't easily tell what's your code and what's Rucio's.
| @@ -0,0 +1,155 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
If we wrote this, it should have our copyright, not theirs.
Update to new version 34.6.0 of constants.py Update to new version of 34.6.0 protocol.py
No description provided.