DM-45473: Fix aarch64 compile errors and rubin env 9 warning #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows tests to pass with small rounding errors, which apparently happen on aarch64.
mwittgen
reviewed
Jul 30, 2024
| @@ -5,6 +5,7 @@ project( | |||
| license : 'GPL-3.0-or-later', | |||
| default_options : ['cpp_std=c++17',], | |||
| ) | |||
| add_project_arguments('-ffp-contract=off', language : 'cpp') | |||
There was a problem hiding this comment.
I don't see this flag propagating to the meson build on aarch64
CFLAGS='-ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O3 -pipe -isy
stem /lsstsw/miniconda/envs/lsst-scipipe-8.0.0/include'
There was a problem hiding this comment.
Also not in any CXXFLAGS . Doesn't show up in the meson log.
There was a problem hiding this comment.
It should show up in build-release/compile_commands.json. Does it not?
There was a problem hiding this comment.
It does not show up on x86 either with an lsstsw build.
There was a problem hiding this comment.
Resolved in that I needed to add it to python/meson.build since the failures were from numpy image-based templated classes. It may not be necessary here but may as well stay for consistency, or if/when I end up adding GSL image classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.