Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-13567: Add tests to ap_pipe #1

Merged
merged 4 commits into from May 17, 2019
Merged

DM-13567: Add tests to ap_pipe #1

merged 4 commits into from May 17, 2019

Conversation

mrawls
Copy link
Collaborator

@mrawls mrawls commented May 3, 2019

Pair coded with @kfindeisen.

Copy link
Contributor

@parejkoj parejkoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How big is this package? Should it be in SQuaRE's list of "don't include this in binary distributions"?

@mrawls
Copy link
Collaborator Author

mrawls commented May 14, 2019

It is a 1.4 GB git-lfs repo, so probably yes. Where does this list live? I made PRs for lsstsw and repos as directed here. Is there an additional step needed so SQuaRE doesn't automatically try to add it to the binaries?

@kfindeisen
Copy link
Member

I'm pretty sure he means the manifest.remap file in lsstsw (which we need to do regardless of the package size, because eups doesn't support Git LFS).

@parejkoj
Copy link
Contributor

Did you get back an answer from SQuaRE about whether the manifest.remap is the only change necessary?

@mrawls
Copy link
Collaborator Author

mrawls commented May 17, 2019

Yes. Josh confirmed that eups products remapped to None in lsst/lsstsw/etc/manifest.remap don't have source packages generated.

@mrawls mrawls merged commit 2271c98 into master May 17, 2019
@kfindeisen kfindeisen deleted the tickets/DM-13567 branch November 22, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants