DM-26326: Remove obs dependency from ap_verify_testdata and ap_pipe_testdata #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
reviewed
Dec 3, 2020
There was a problem hiding this comment.
I'm vaguely surprised that the table file is now empty: maybe a short note in it explaining why? See, for example: https://github.com/lsst/testdata_jointcal/blob/master/ups/testdata_jointcal.table
|
Isn't that standard for data repositories? I looked at |
|
I guess I'd argue that they all should have a comment about what things you need to setup in order to actually use them, then. |
kfindeisen
force-pushed
the
tickets/DM-26326
branch
from
f75281d
to
2da6d62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the sole EUPS dependency from this package.