Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

DM-13530: Generalize ingestion to non-HiTS data #6

Merged
merged 2 commits into from
Apr 20, 2018
Merged

DM-13530: Generalize ingestion to non-HiTS data #6

merged 2 commits into from
Apr 20, 2018

Conversation

kfindeisen
Copy link
Member

This PR adds HiTS-specific information to the dataset, keeping ap_verify from having to hardcode it.

@kfindeisen
Create dataset-specific ingestion config.
637ddef 
This file allows the dataset to be ingested without additional
user-specified information.
@kfindeisen
Support config overrides for DatasetIngestTask.
3a2bcea 
Despite not being a CmdLineTask, DatasetIngestTask will respect
obs-package- and camera-specific override files following standard
Stack conventions.
@kfindeisen kfindeisen requested a review from mrawls April 5, 2018 20:02
@kfindeisen kfindeisen mentioned this pull request Apr 5, 2018
Merged
mrawls
mrawls approved these changes Apr 19, 2018
View reviewed changes
Copy link
Contributor

@mrawls mrawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are fine. If you decide to use the name IgnoreFiles in place of BadFiles, be sure to update it here as well.

@kfindeisen kfindeisen merged commit 3a2bcea into master Apr 20, 2018
@kfindeisen kfindeisen deleted the tickets/DM-13530 branch November 4, 2020 20:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrawls mrawls mrawls approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kfindeisen @mrawls