Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DM-6126] Add patch to fix building with GCC 5.x on modern linux distributions. #1

Merged
merged 1 commit into from May 17, 2016

Conversation

jmatt
Copy link
Contributor

@jmatt jmatt commented May 17, 2016

Add a patch to address this compiler error which happens on Ubuntu 16.04 due to GCC 5.x incompatibility:

'''
permutedsort.c:125:2: error: non-floating-point argument in call to function '__builtin_isnan'
COMPARE(f1, f2, <, >);
...
permutedsort.c:131:2: error: non-floating-point argument in call to function '__builtin_isnan'
COMPARE(f1, f2, >, <);
'''

Mailing list discussion

GitHub commit

@timj
Copy link
Member

timj commented May 17, 2016

Can you confirm that this is compiler version related and not ubuntu as such? If it's an issue with a modern GCC then can you please make that the commit message (maybe with body of the message indicating that it was first discovered in Ubuntu 16.04).

@timj
Copy link
Member

timj commented May 17, 2016

oh, and the words in this PR should be in the commit message.

	new file:   patches/001-IncorrectTestForIsNaN.patch
@jmatt jmatt changed the title [DM-6126] Add patch to fix build on Ubuntu 16.04 and recent Fedora distributions. [DM-6126] Add patch to fix building with GCC 5.x on modern linux distributions. May 17, 2016
@jmatt
Copy link
Contributor Author

jmatt commented May 17, 2016

I've updated the commit, PR comment and title to reference GCC 5.x.

@jmatt jmatt merged commit ae735ff into lsst-dm:master May 17, 2016
@timj
Copy link
Member

timj commented May 17, 2016

Much better, but the commit message body is still missing the provenance information from the PR text.

@timj
Copy link
Member

timj commented May 17, 2016

Ok. It's merged. Too late 😄

@jmatt
Copy link
Contributor Author

jmatt commented May 17, 2016

Yeah we'll clear it up so I can do it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants