DM-22378: Handle release candidate astropy versions #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
commented
Nov 27, 2019
4.0.0rc1 is compared as if it is v4.0.0
timj
force-pushed
the
tickets/DM-22378
branch
from
786f768
to
43378b1
Compare
jdswinbank
reviewed
Nov 27, 2019
* Explicitly loops and checks each component * Reuses the code for splitting version * Only pads with number of elements that are required
|
The new code is simple and easy to follow; thanks. It won't handle development or post releases specified following PEP-440. Do Astropy use a PEP-440 scheme? If so, might be worth adding that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.