Remove call to del #2

mfisherlevine · 2017-10-02T18:33:17Z

Move logic to a finalise() method, as del is always called in py3
but this is not the case in py2. Also, remove the call to super()
as it was unnecessary and this way is equivalent but safer.

Move logic to a finalise() method, as __del__ is always called in py3 but this is not the case in py2. Also, remove the call to super() as it was unnecessary and this way is equivalent but safer.

natelust

In general if you have also in a commit message that means you should have two commits. This is such small changes that I will simply lean on you hard to consider the wisdom using best practices rather than formally require a change.

Remove call to __del__

30573c6

Move logic to a finalise() method, as __del__ is always called in py3 but this is not the case in py2. Also, remove the call to super() as it was unnecessary and this way is equivalent but safer.

natelust reviewed Oct 3, 2017

View reviewed changes

mfisherlevine merged commit be69b68 into master Oct 3, 2017

ktlim deleted the tickets/DM-11653 branch August 25, 2018 04:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove call to del #2

Remove call to del #2

mfisherlevine commented Oct 2, 2017

natelust left a comment

Remove call to __del__ #2

Remove call to __del__ #2

Conversation

mfisherlevine commented Oct 2, 2017

natelust left a comment

Choose a reason for hiding this comment

Remove call to del #2

Remove call to del #2